[TASK] Guard against infinite loop in parseList - #1427
Merged
Conversation
This can't be tested because there are currently no cases that would fail the test without the change. It is there as a preventative double-lock measure to make sure any future code changes do not introduce an infinite loop. It's a slight unoptimization, as it adds what should be a redundant runtime check, but at miniscule performance cost versus the value of preventing a waste of CPU power and memory in the case that something goes wrong.
JakeQZ
force-pushed
the
task/guard-infinite-loop
branch
from
December 14, 2025 18:50
6e845af to
6f70c5a
Compare
JakeQZ
added
the
developer-specific
JakeQZ
marked this pull request as ready for review
December 14, 2025 18:54
Collaborator
Author
|
Longer term it would probably be good to refactor the logic in |
oliverklee
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can't be tested because there are currently no cases that would fail the test without the change.
It is there as a preventative double-lock measure to make sure any future code changes do not introduce an infinite loop.
It's a slight unoptimization,
as it adds what should be a redundant runtime check, but at miniscule performance cost versus the value of preventing a waste of CPU power and memory in the case that something goes wrong.